[PATCH] D97427: [AMDGPU] Do not annotate an else branch if there is a kill

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

In D97427#2599162 <https://reviews.llvm.org/D97427#2599162>, @critson wrote:

> Returning to your question about "transitive successors".
> I do not think this is an issue -- the problem is with else being put in the same block as a kill causing that kill to executed as if it was part of the preceding if-branch.
> If we place an else in a transitive successor then that implies the kill was genuinely part of the if-branch, which is fine.

You could theoretically have a split block that doesn't actually change control flow (i.e. one that just unconditionally branches to another block that only has the one predecessor). That's unlikely to happen in practice since those will get put back together again. Given that at this point we're just sort of waiting for this scheme to die, I wouldn't worry too much about this edge case


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97427/new/

https://reviews.llvm.org/D97427