[PATCH] D97726: [sanitizers] [windows] Use InternalMmapVector instead of silencing -Wframe-larger-than

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 10 01:24:10 PST 2021


mstorsjo marked an inline comment as done.
mstorsjo added inline comments.


================
Comment at: compiler-rt/lib/sanitizer_common/sanitizer_win.cpp:599
+  if (!ReadFromFile(fd, &buf[0], buf.size(), &bytes_read) ||
       bytes_read != sizeof(buf))
     return 0;
----------------
russell.gallop wrote:
> I think that this line needs changing from sizeof(buf) to buf.size() as well.
Doh, thanks for catching it!, fixed now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97726/new/

https://reviews.llvm.org/D97726



More information about the llvm-commits mailing list