[PATCH] D98316: [rs4gc] Simplify code by cloning existing instructions when inserting base chain [NFC]

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 9 21:30:04 PST 2021


reames created this revision.
reames added a reviewer: skatkov.
Herald added subscribers: dantrushin, hiraditya, mcrosier.
Herald added a reviewer: bollu.
reames requested review of this revision.
Herald added a project: LLVM.

This is nfc, but just complicated I wanted a separate set of eyes.  The motivation is a) cleaner code, and b) reducing some spurious test changes in D98315 <https://reviews.llvm.org/D98315>.

Previously we created a new node, then filled in the pieces.  Now, we clone the existing node, then change the respective fields.  The only change in handling is with phis since we have to handle multiple incoming edges from the same block a bit differently.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D98316

Files:
  llvm/lib/Transforms/Scalar/RewriteStatepointsForGC.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D98316.329527.patch
Type: text/x-patch
Size: 5827 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210310/a6a76506/attachment.bin>


More information about the llvm-commits mailing list