[PATCH] D97007: [lld-macho] Define __mh_bundle_header as symbol (similar to ___dso_handle)

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 9 21:19:06 PST 2021


int3 added inline comments.


================
Comment at: lld/MachO/SymbolTable.h:69-71
+      // FIXME: Make every symbol (including absolute symbols) contain a
+      // reference to their originating file, then add that file name to this
+      // error message. dynamic_lookup symbols don't have an originating file.
----------------
oontvoo wrote:
> @int3: Why do we need this FIXME?  (DSO handle and other mh_* stuff don't have an originating file ...)
ah, that was already done in D94316, so this FIXME can be removed


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97007/new/

https://reviews.llvm.org/D97007



More information about the llvm-commits mailing list