[PATCH] D98122: [rs4gc] don't duplicate existing values which are provably base pointers

Serguei Katkov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 9 20:15:47 PST 2021


skatkov added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/RewriteStatepointsForGC.cpp:908
+      Value *BDV = Pair.first;
+      auto canPruneInput = [&](Value *V) {
+        Value *BDV = findBaseOrBDV(V, Cache);
----------------
nit: not sure but consider moving lambda out of a loop.
The loop becomes small and easy to read.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98122/new/

https://reviews.llvm.org/D98122



More information about the llvm-commits mailing list