[PATCH] D97703: [AsmParser][SystemZ][z/OS] Introducing HLASM Comment Syntax

Anirudh Prasad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 9 14:44:11 PST 2021


anirudhp added a comment.

In D97703#2606944 <https://reviews.llvm.org/D97703#2606944>, @scott.linder wrote:

> Thank you for making the changes, this LGTM modulo feedback from others on the testing

Hi @scott.linder ,
I was able to come up with a unit test instead. The unit test checks the behaviour the `RestrictCommentStringToStartOfStatement` attribute. Hopefully this should answer the testing issue, and should be sufficient as a "test" for the patch, until more lit tests can be added (once the necessary MCStreamer and Object file support for the z/OS target is added in)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97703/new/

https://reviews.llvm.org/D97703



More information about the llvm-commits mailing list