[llvm] 23fd647 - [SLP] remove dead null check; NFC

Sanjay Patel via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 9 14:43:22 PST 2021


Author: Sanjay Patel
Date: 2021-03-09T17:43:07-05:00
New Revision: 23fd647cc6b8d25076188492e6424eee60c31326

URL: https://github.com/llvm/llvm-project/commit/23fd647cc6b8d25076188492e6424eee60c31326
DIFF: https://github.com/llvm/llvm-project/commit/23fd647cc6b8d25076188492e6424eee60c31326.diff

LOG: [SLP] remove dead null check; NFC

We cast<> to Instruction (not dyn_cast<>), so we already
required/assumed that Cmp is not null.

Added: 
    

Modified: 
    llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp b/llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp
index 065ddca81789..10ee163bcfcc 100644
--- a/llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp
+++ b/llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp
@@ -6682,7 +6682,7 @@ class HorizontalReduction {
                             bool IsRedOp) {
     if (IsRedOp && isCmpSel(Kind)) {
       auto *Cmp = cast<Instruction>(cast<SelectInst>(I)->getCondition());
-      return I->getParent() == BB && Cmp && Cmp->getParent() == BB;
+      return I->getParent() == BB && Cmp->getParent() == BB;
     }
     return I->getParent() == BB;
   }


        


More information about the llvm-commits mailing list