[PATCH] D96628: [VPlan] Add plain text (not DOT's digraph) dumps

[Florian Hahn via Phabricator via llvm-commits]

fhahn added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/VPlan.cpp:53
+cl::opt<bool>
+    PrintExecutedVPlan("print-executed-vplan", cl::init(false), cl::Hidden,
+                       cl::desc("Dump the VPlan that is being executed to "
----------------
I think having an option to just print the plans make sense, but as a first step, should we start with an option to just toggle between dot printing and regular printing for when using `-debug`?


================
Comment at: llvm/lib/Transforms/Vectorize/VPlan.cpp:866
+  // Use no indentation as we need to wrap the lines into quotes ourselves.
+  BasicBlock->print(SS, "", SlotTracker);
+  SmallVector<StringRef, 0> Lines;
----------------
Could you add a comment explaining that we first print the block and then split up/reconstruct the output with the .dot syntax>


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96628/new/

https://reviews.llvm.org/D96628