[PATCH] D89049: [AIX][XCOFF] print out the traceback info

[Digger Lin via Phabricator via llvm-commits]

DiggerLin marked 6 inline comments as done.
DiggerLin added inline comments.


================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.h:155
+using namespace llvm;
+unsigned getInstStartColumn(const MCSubtargetInfo &STI);
+void printRawData(llvm::ArrayRef<uint8_t> Bytes, uint64_t Address,
----------------
DiggerLin wrote:
> Xiangling_L wrote:
> > May I ask why we don't put these two functions in objdump namespace as well?
> 
> the call stack as 
> PrettyPrinter::printInst() ->printRawData() ->getInstStartColumn()
> 
> the class PrettyPrinter is defined in anonymous  namespace  and  these two new function only used by the class PrettyPrinter. So I define two function as the same namespace as  PrettyPrinter .
sorry . I change the above comment 
these two new function only used by the class PrettyPrinter
to 
these two new function is used by the class PrettyPrinter


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89049/new/

https://reviews.llvm.org/D89049