[PATCH] D98226: [CSSPGO][llvm-profgen] Fix getCanonicalFnName usage in llvm-profgen

Hongtao Yu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 9 12:46:50 PST 2021


hoy added inline comments.


================
Comment at: llvm/tools/llvm-profgen/PseudoProbe.cpp:165
     uint32_t NameSize = readUnsignedNumber<uint32_t>();
-    StringRef Name = readString(NameSize);
+    StringRef Name = FunctionSamples::getCanonicalFnName(readString(NameSize));
 
----------------
wlei wrote:
> hoy wrote:
> > Give it "selected" to avoid dropping .__unique suffix?
> The "selected" is already the default parameter, you can find it in https://reviews.llvm.org/D96932.
Sounds good, thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98226/new/

https://reviews.llvm.org/D98226



More information about the llvm-commits mailing list