[PATCH] D98220: [WPD][ELF] Allow whole program devirtualization for version script localized symbols

Nathan Lanza via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 9 11:38:16 PST 2021


lanza added a comment.

> An older version of the patch had the vtables marked "hidden" in the LLVM assembly. My point was that clang would have given them a non-public vcall_visibility in that case.

Ahh, sorry, I missed that!

> The patch and the test case have changed though, so that now the local binding comes from the linker version script and not the input IR, which is more consistent with the case I believe you are trying to handle?

Correct.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98220/new/

https://reviews.llvm.org/D98220



More information about the llvm-commits mailing list