[PATCH] D98226: [CSSPGO][llvm-profgen] Fix getCanonicalFnName usage in llvm-profgen

Tue Mar 9 10:27:24 PST 2021

wlei added a comment.

In D98226#2612949 <https://reviews.llvm.org/D98226#2612949>, @wenlei wrote:

> Looks like this is the only place where canonicalization is missing. Would be good to have a test case for proper profile name canonicalization (removing other suffix, but not unique), otherwise looks good.

Yeah, two places for the dwarf-based name canonicalization: one in the symbolizer and another is for the call target name. for probe, only need to call getCanonicalFnName after func name decoding.

Good point to add test case, will add it later.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98226/new/

https://reviews.llvm.org/D98226