[PATCH] D98225: [flang] Sort symbols by creation order

[Pete Steinfeld via Phabricator via llvm-commits]

PeteSteinfeld added inline comments.


================
Comment at: flang/include/flang/Semantics/symbol.h:658
+  std::size_t sortIndex_; // to implement "operator<" platform independently
+  static std::size_t nameCount_;
   Attrs attrs_;
----------------
tskeith wrote:
> It would make more sense to put `nameCount_` in `Symbols`. And `symbolCount_` would be a better name.
Great suggestions.  And for reasons I don't understand, I can initialize static data members directly in the definition of a template class.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98225/new/

https://reviews.llvm.org/D98225