[PATCH] D98218: [LSR] fix a issue that LoopStrengthReduction drop debug location unnecessarily
Jeremy Morse via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Mar 9 09:12:16 PST 2021
jmorse added a comment.
In principle this looks good, but as @djtodoro points out it needs a test.
Note also the concern I had in PR48067, OptimizeLoopTermCond might move the newly created instruction around, which needs to obey the source-location-update rules. If the test case could cover this scenario too, that'd be great coverage to gain, and show that it's doing-the-right-thing.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98218/new/
https://reviews.llvm.org/D98218
More information about the llvm-commits
mailing list