[PATCH] D98240: [VectorCombine] Simplify to scalar store if only one element updated

[Sanjay Patel via Phabricator via llvm-commits]

spatel added a subscriber: asbirlea.
spatel added a comment.

Since the original proposal, MemorySSA has evolved. I still don't know much about that though. cc @asbirlea @nikic to see if this implementation is ok or should we use MemorySSA here?



================
Comment at: llvm/lib/Transforms/Vectorize/VectorCombine.cpp:777
+  StoreInst *SI = dyn_cast<StoreInst>(&I);
+  if (SI == nullptr || !SI->isSimple() ||
+      !SI->getValueOperand()->getType()->isVectorTy())
----------------
Can shorten:
  if (!SI || !SI->isSimple() ...)


================
Comment at: llvm/lib/Transforms/Vectorize/VectorCombine.cpp:829
       continue;
     // Do not delete instructions under here and invalidate the iterator.
     // Walk the block forwards to enable simple iterative chains of transforms.
----------------
This line of the comment is not accurate now. Remove or update.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98240/new/

https://reviews.llvm.org/D98240