[PATCH] D95230: Save and restore previous terminal after setting the terminal for checking if terminal supports colors.

Augusto Noronha via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 9 08:09:11 PST 2021


augusto2112 added a comment.

> We'll still need to be careful about using this functionality on the lldb side though. This fix will only help if there is proper synchronization between using this function and libedit initialization

The only way I think this could have adverse effects is if some component is relying on this function to clear the current settings, which would stop happening after this change.

@labath can this be merged or do we need someone else to approve it? I tagged everyone I found that could review it, but maybe we should add more people?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95230/new/

https://reviews.llvm.org/D95230



More information about the llvm-commits mailing list