[PATCH] D90868: [IR] Define @llvm.ptrauth intrinsics.

Kristof Beyls via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 9 07:58:07 PST 2021


kristof.beyls added a comment.

In D90868#2613237 <https://reviews.llvm.org/D90868#2613237>, @rjmccall wrote:

> Before we get too far into editorial review, I think we should step back and ask what actually needs to be in this document.  In particular, I'm not sure that the discussion of how pointer authentication can be used in an ABI is really appropriate for LLVM-level documentation.  We should discuss the formal model we want the intrinsics/constant to provide — secret key registers, well-formed pointers, arbitrary discriminators — and just link to other documentation (e.g. the much longer white paper in the clang docs) for the benefit of people who are curious about how this can be used.

Good point, that makes sense to me. After a quick glance it seems there are only 2 short paragraphs that maybe need to be removed (or be replaced with pointers to the other documentation).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90868/new/

https://reviews.llvm.org/D90868



More information about the llvm-commits mailing list