[PATCH] D98174: [MCA] Add tests for IPC on Cortex-A55

Andrew Savonichev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 9 07:00:56 PST 2021


asavonic added a comment.

In D98174#2613867 <https://reviews.llvm.org/D98174#2613867>, @andreadb wrote:

> One last question.
> What is the plan with the SDIV test cases? I don't think that there is anything that we can do to improve that simulation, since it would require knowledge that isn't available at simulation time. The risk is to end up with a test which isn't very useful in practice (it will always be marked as XFAIL). In which case, I suggest to remove those DIV tests entirely.

They are not very useful as "tests", I agree, but they can be useful as a documentation, 
highlighting the cases where MCA and hardware do not match. Although there is no point
in having two tests for the same issue, so we can remove one of them.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98174/new/

https://reviews.llvm.org/D98174



More information about the llvm-commits mailing list