[PATCH] D98257: [flang][driver] Merge test/Driver and test/Flang-Driver directories
Tim Keith via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Mar 9 06:59:57 PST 2021
tskeith added a comment.
In general, I don't think it's necessary to have tests specifically for the old driver. Testing the functionality they have in common is good enough. The two I pointed out are pretty trivial anyway.
================
Comment at: flang/test/Driver/driver-version.f90:4
+! TODO: Currently this works for `flang-new` and `f18`. Once `f18` is no
+! longer available, refine this to suite `flang-new` better.
+
----------------
I think it would be okay to make this one require the new driver.
"suite" -> "suit"
================
Comment at: flang/test/Driver/input-from-stdin-unparse.f90:5
+! replace this with input-from-stdin.f90. But once `f18` is removed, we
+! can safely delete this.
+
----------------
I think it's okay to get rid of this one.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98257/new/
https://reviews.llvm.org/D98257
More information about the llvm-commits
mailing list