[PATCH] D97609: [RISCV] Add support for VECTOR_REVERSE for scalable vector types.

[Fraser Cormack via Phabricator via llvm-commits]

frasercrmck accepted this revision.
frasercrmck added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:2788
+      // Reassemble the low and high pieces reversed.
+      // FIXME: This is a CONCAT_VECTORS.
+      SDValue Res =
----------------
craig.topper wrote:
> frasercrmck wrote:
> > Is there an issue with using CONCAT_VECTORS?
> We don’t seem to have implemented CONCAT_VECTORS for scalable vectors yet so it went to the stack.
Ah of course; we only added it for fixed-length vectors since it's common during legalization.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97609/new/

https://reviews.llvm.org/D97609