[PATCH] D93300: [PowerPC] Exploit paddi instruction on Power 10 for constant materialization

Lei Huang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 9 06:47:18 PST 2021


lei added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelDAGToDAG.cpp:1050-1052
+  auto getI32Imm = [CurDAG, dl](unsigned Imm) {
+    return CurDAG->getTargetConstant(Imm, dl, MVT::i32);
+  };
----------------
I see this lambda defined in at least 2 other functions in this file.   Maybe it's time to make this an actual function rather then a lambda within the different functions.  But that can be a followup NFC patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93300/new/

https://reviews.llvm.org/D93300



More information about the llvm-commits mailing list