[PATCH] D98247: [X86][AMX] Prevent transforming load pointer from <256 x i32>* to x86_amx*.

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 9 04:59:56 PST 2021


lebedev.ri requested changes to this revision.
lebedev.ri added a comment.
This revision now requires changes to proceed.

In D98247#2613689 <https://reviews.llvm.org/D98247#2613689>, @LuoYuanke wrote:

> In D98247#2613648 <https://reviews.llvm.org/D98247#2613648>, @lebedev.ri wrote:
>
>> I'm not really convinced this is moving in the right direction.
>> other side of the problem should be fixed.
>
> Thanks for review. Prohibiting the transform of pointer cast from <256 x i32>* to x86_amx* looks straight forward.

Hm. Two things: pointer types are going away, and we can't make any optimizations based on the pointer type regardless.

> I also try another way in patch https://reviews.llvm.org/D93788, but it seems not as good as prohibit pointer cast. Do you have any suggestions? I would like to try if you have any good idea on it.




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98247/new/

https://reviews.llvm.org/D98247



More information about the llvm-commits mailing list