[PATCH] D98235: [InstCombine][SimplifyLibCalls] An extra sqrtf was produced because of transformations in optimizePow function

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 9 04:55:16 PST 2021


spatel added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/SimplifyLibCalls.cpp:1818
+      hasFloatVersion(Name))
+    Shrunk = optimizeBinaryDoubleFP(Pow, B, true);
+
----------------
We can localize "Shrunk" to make this clearer:
  if (Value *Shrunk = optimizeBinaryDoubleFP(Pow, B, true))
    return Shrunk;

(and remove the declaration at line 1707).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98235/new/

https://reviews.llvm.org/D98235



More information about the llvm-commits mailing list