[PATCH] D97970: [RISCV] Make the hasStdExtM() check in RISCVInstrInfo::getVLENFactoredAmount emit a diagnostic rather than an assert.

Fraser Cormack via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 9 01:57:50 PST 2021


frasercrmck accepted this revision.
frasercrmck added a comment.
This revision is now accepted and ready to land.

In D97970#2611530 <https://reviews.llvm.org/D97970#2611530>, @craig.topper wrote:

> Maybe. I'm not sure if I we're able to inject a call at the point in the compiler where this is used.

Yeah, I thought that might be case. Perhaps we'd have to lower it differently/earlier without M. Since that code would be elsewhere, this diagnostic is still an improvement so I'm happy for it to go in. We can always come back to this issue if/when it's important.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97970/new/

https://reviews.llvm.org/D97970



More information about the llvm-commits mailing list