[PATCH] D97837: [InstCombine] Remove gc.relocate duplicates

Tue Mar 9 01:25:26 PST 2021

skatkov added a comment.

In D97837#2612992 <https://reviews.llvm.org/D97837#2612992>, @skatkov wrote:

> In D97837#2609180 <https://reviews.llvm.org/D97837#2609180>, @reames wrote:
>
>> Serguei, I took another look at just improving rs4gc, and for some reason this time it seemed much easier than we'd talked about it last time.  I'd be curious to know if https://reviews.llvm.org/D98122 addresses your original issues (without any of the GVN patches).
>
> It does not address original issue.

ok, I was wrong! The patch D98122 <https://reviews.llvm.org/D98122> (+instcombine as clean-up) produces the same best result as I was able to get using other approaches.
To me it is a best decision and I'm ready to abandon this change for now if there will no be other producers of duplicated phi nodes.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97837/new/

https://reviews.llvm.org/D97837