[PATCH] D97111: [RISCV] change rvv frame layout

Roger Ferrer Ibanez via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 9 00:56:29 PST 2021


rogfer01 accepted this revision.
rogfer01 added a comment.
This revision is now accepted and ready to land.

Except for the minor comments above, LGTM.



================
Comment at: llvm/test/CodeGen/RISCV/rvv/rvv-framelayout.ll:50
+
+define void @rvv_overaligned(i64 %n, i64 %i) nounwind {
+; CHECK-LABEL: rvv_overaligned:
----------------
This test doesn't seem to be using `%n` or `%i`. My fault: I accidentally copy-pasted it in my earlier suggestion.


================
Comment at: llvm/test/CodeGen/RISCV/rvv/rvv-framelayout.ll:87
+
+define void @rvv_val_and_overaligned(i64 %n, i64 %i) nounwind {
+; CHECK-LABEL: rvv_val_and_overaligned
----------------
typo: `rvv_val` → `rvv_vla`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97111/new/

https://reviews.llvm.org/D97111



More information about the llvm-commits mailing list