[PATCH] D98173: [compiler-rt] Normalize i?86 to i386 and armv* to arm for COMPILER_RT_DEFAULT_TARGET_ARCH

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added a comment.

In D98173#2613207 <https://reviews.llvm.org/D98173#2613207>, @rprichard wrote:

> I think this is OK for Android.
>
> The toplevel armhf mapping seems redundant now -- can it be removed? (https://github.com/llvm/llvm-project/blob/1200f85818d16e4f0a57c503e186df7a8ad92435/compiler-rt/CMakeLists.txt#L114)

Yep, I was planning to remove that one afterwards.

> I suppose this wildcard is also redundant: https://github.com/llvm/llvm-project/blob/1200f85818d16e4f0a57c503e186df7a8ad92435/compiler-rt/cmake/base-config-ix.cmake#L171.

Not all of it, this patch only normalizes the 32 bit ones. I guess one could try to normalize amd64 into x86_64 too, but this would still need to be at least i386 + x86_64.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98173/new/

https://reviews.llvm.org/D98173