[PATCH] D98220: [WPD][ELF] Allow whole program devirtualization for version script localized symbols

Nathan Lanza via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 8 23:47:55 PST 2021


lanza added a comment.

> Well right now they are marked with public visibility, which is the same thing as not having any vcall_visibility. Since they are marked in the IR as having hidden visibility, clang presumably should have marked them with a more restricted vcall_visibility (linkage unit level).

Hmm? You first said "they are marked with public visibility" and then said "they are marked in the IR as having hidden visibility." I don't follow. A `__attribute__(visibility("hidden")))` symbol gets the `hidden` attr.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98220/new/

https://reviews.llvm.org/D98220



More information about the llvm-commits mailing list