[PATCH] D98179: [lit] Sort test start times based on prior test timing data

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added a comment.

LGTM! 
In general a bit more code documentation could be nice. It seems all obvious in the context of this patch, but someone reading the codebase may not find this as trivial as it seems.



================
Comment at: llvm/utils/lit/lit/cl_arguments.py:157
     selection_group.add_argument("-i", "--incremental",
-            help="Run modified and failing tests first (updates mtimes)",
+            help="Start modified and failing tests first (updates mtimes)",
             action="store_true")
----------------
Seems like you deprecated the option, can you update the doc to reflect it?


================
Comment at: llvm/utils/lit/lit/discovery.py:144
+    if os.path.exists(test_times_file):
+        file = open(test_times_file, 'r')
+        for line in file.readlines():
----------------
Maybe add a `if litConfig.debug:` trace here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98179/new/

https://reviews.llvm.org/D98179