[PATCH] D98223: [lld-macho] implement options -(un)exported_symbol(s_list)

[Vy Nguyen via Phabricator via llvm-commits]

oontvoo added inline comments.


================
Comment at: lld/MachO/Driver.cpp:728
+void SymbolPatterns::insert(StringRef symbolName) {
+  if (symbolName.find_first_of("*?[") == StringRef::npos)
+    literals.insert(symbolName);
----------------
nit: for completeness, consider adding `]` too? 
(if symbolName had `]` without other stuff, it's likely malformed and it would be good to error out)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98223/new/

https://reviews.llvm.org/D98223