[PATCH] D98145: [FastISel] Don't trivially kill extractvalues (PR49467)

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/FastISel.cpp:267
   return I->hasOneUse() &&
          !(I->getOpcode() == Instruction::BitCast ||
            I->getOpcode() == Instruction::PtrToInt ||
----------------
Should this list of exception opcodes just be hoisted up to its own if+"return false" with a more directed comment? It's not important that we check I->hasOneUse() before them is it?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98145/new/

https://reviews.llvm.org/D98145