[PATCH] D98119: Fix a crash in DWARFUnit::getInlinedChainForAddress in case of unexpected DWARF information.

[David Blaikie via Phabricator via llvm-commits]

dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

Seems good enough - though if you're interested in this code being able to handle arbitrarily broken DWARF, this function probably needs to be changed to be able to return some kind of failure (like llvm::Error) for the case where the parent walk reaches DIE types that would never be found in the usual scope chain (ie: something other than inlined_subroutines and lexical_blocks (or lexical_scopes, I can never remember the right tag name)) - because the caller's probably going to be pretty confused by other DIEs appearing in this list.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98119/new/

https://reviews.llvm.org/D98119