[PATCH] D98118: GlobalISel: Partially fix handling of byval arguments
Amara Emerson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Mar 8 14:22:48 PST 2021
aemerson added a comment.
It turns out that we rarely use byval at all on AArch64, so that's why this wasn't found out earlier.
================
Comment at: llvm/lib/CodeGen/GlobalISel/CallLowering.cpp:651
+ // result for outgoing byval parameters.
+ if (!Handler.isIncomingArgumentHandler())
+ continue;
----------------
I assume a fix for this case is coming soon? Otherwise I think we should fall back here.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98118/new/
https://reviews.llvm.org/D98118
More information about the llvm-commits
mailing list