[PATCH] D97881: [CodeView] Truncate Long Type Names With A Hash

[Reid Kleckner via Phabricator via llvm-commits]

rnk added inline comments.


================
Comment at: llvm/lib/DebugInfo/CodeView/TypeRecordMapping.cpp:186-187
+
+        StringRef N = NameB;
+        StringRef U = UniqueB;
+        error(IO.mapStringZ(N));
----------------
bwyma wrote:
> rnk wrote:
> > Are these locals necessary? We should be able to map NameB and UniqueB directly.
> The mapStringZ() calls perform both reading and writing, requiring a StringRef& (string-ref-reference). Its ugly and I welcome any suggestions to improve it.
I see. I think it's fine as is.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97881/new/

https://reviews.llvm.org/D97881