[PATCH] D98161: [NFC][IR] Replace isa<ScalableVectorType> with a predicator function.

Hsiangkai Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 8 13:33:29 PST 2021


HsiangKai added a comment.

In D98161#2610561 <https://reviews.llvm.org/D98161#2610561>, @lebedev.ri wrote:

> I'm not convinced this is correct.
> For example, `shufflevector` only works on vectors, so i don't see why a "struct with scalable vector" is even relevant there.

I think it is checking isScalableType is some cases and checking isScalableVectorType in other cases. I will separate them.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98161/new/

https://reviews.llvm.org/D98161



More information about the llvm-commits mailing list