[PATCH] D98063: [flang][fir] Add the pre-code gen rewrite pass and codegen ops.

Eric Schweitz via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 8 13:25:27 PST 2021


schweitz added inline comments.


================
Comment at: flang/lib/Optimizer/CodeGen/PreCGRewrite.cpp:299
+
+/// Convert FIR's structured control flow ops to CFG ops.  This conversion
+/// enables the `createLowerToCFGPass` to transform these to CFG form.
----------------
SouraVX wrote:
> NIT: These comments doesn't make sense here? Must be gone in while preparing the patch ?
> Could you please update them accordingly.
Removed. The pass is now defined in a tablegen file.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98063/new/

https://reviews.llvm.org/D98063



More information about the llvm-commits mailing list