[PATCH] D98192: [dfsan] Tracking origins at memory transfer

stephan.yichao.zhao via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 8 11:40:32 PST 2021


stephan.yichao.zhao marked an inline comment as done.
stephan.yichao.zhao added inline comments.


================
Comment at: compiler-rt/test/dfsan/origin_memcpy.c:19
+void fn_g(int a, int b) {
+  xx[idx] = a; xx[idx + 10] = b;
+}
----------------
morehouse wrote:
> Why don't we get an origin saved for these stores?
Thank you for catching this. Added the missing tracks in the 3 test cases.


================
Comment at: compiler-rt/test/dfsan/origin_unaligned_memtrans.c:44
+  return 0;
+}
+
----------------
morehouse wrote:
> This test seems to cover all the cases from origin_memmove.c and origin_memcpy.c.  Do we still need those?
Updated origin_memmove.cc to use aligned addresses.
Then this file focuses on unaligned addresses.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98192/new/

https://reviews.llvm.org/D98192



More information about the llvm-commits mailing list