[PATCH] D94648: [amdgpu] Implement lower function LDS pass

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPULowerModuleLDSPass.cpp:141
+
+  static void removeFromUsedList(Module &M, StringRef Name,
+                                 SmallPtrSetImpl<Constant *> &ToRemove) {
----------------
JonChesterfield wrote:
> arsenm wrote:
> > Needs a comment
> A comment saying what? The function and helper does what the name and parameter types claim it'll do in almost as boring a fashion as possible.
On first read it sounds very generic, and not related to the special intrinsic global variables. I had to read the function to see what it actually did


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94648/new/

https://reviews.llvm.org/D94648