[PATCH] D98038: [AMDGPU] Fix the dead frame indices during custom spill lowering.

[Christudasan Devadasan via Phabricator via llvm-commits]

cdevadas added a comment.

By deleting the debug value we prevent its debug info. Not sure that's the right thing to do. 
This patch is meant to be only a short-term fix. If we couldn't have a long-term solution by better handling the spills, we have to replace the noreg with a valid register in the future as the FIXME says.



================
Comment at: llvm/lib/Target/AMDGPU/SILowerSGPRSpills.cpp:405
+        if (MI.isDebugValue() && MI.getOperand(0).isFI() &&
+            SpillFIs[MI.getOperand(0).getIndex()]) {
+          MI.getOperand(0).ChangeToRegister(Register(), false /*isDef*/);
----------------
arsenm wrote:
> You can just check if the stack ID is SGPR spill, you don't need the custom set
There will be VGPR spills too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98038/new/

https://reviews.llvm.org/D98038