[PATCH] D97847: Use LoopNest as the primary object on which LoopInterchange operates

[Whitney Tsang via Phabricator via llvm-commits]

Whitney added inline comments.


================
Comment at: llvm/include/llvm/Analysis/LoopNestAnalysis.h:153
+  /// of the outer loop.
+  void interchangeNestedLoops(unsigned OuterLoopId, unsigned InnerLoopId) {
+    assert((Loops[InnerLoopId]->getParentLoop() == Loops[OuterLoopId] &&
----------------
Thinking we should have a more generic set function, like setLoops?


================
Comment at: llvm/lib/Transforms/Scalar/LoopInterchange.cpp:504
 #endif
-      Changed |= Interchanged;
+      Changed = true;
     }
----------------
why this change?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97847/new/

https://reviews.llvm.org/D97847