[PATCH] D98058: [InstCombine] Simplify phis with incoming pointer-casts.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 8 05:29:25 PST 2021


fhahn updated this revision to Diff 328982.
fhahn added a comment.

In D98058#2607220 <https://reviews.llvm.org/D98058#2607220>, @nikic wrote:

> This needs tests for addrspacecast, I don't think it's handled correctly.

Right, stripPointerCasts also looks through addrspacecast. I updated the code to use  CastInst::CreatePointerCast, which should automatically use the right type of cast.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98058/new/

https://reviews.llvm.org/D98058

Files:
  llvm/lib/Transforms/InstCombine/InstCombinePHI.cpp
  llvm/test/Transforms/InstCombine/phi-pointercasts.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D98058.328982.patch
Type: text/x-patch
Size: 5660 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210308/f1e755ee/attachment.bin>


More information about the llvm-commits mailing list