[PATCH] D98011: [X86][NFC] Adding one flag to imply whether the instruction should check the predicate when compress EVEX instructions to VEX encoding.

Mon Mar 8 05:07:53 PST 2021

pengfei added a comment.

In D98011#2610900 <https://reviews.llvm.org/D98011#2610900>, @lebedev.ri wrote:

> In D98011#2610381 <https://reviews.llvm.org/D98011#2610381>, @LiuChen3 wrote:
>
>> In D98011#2605726 <https://reviews.llvm.org/D98011#2605726>, @lebedev.ri wrote:
>>
>>> Tests, and some words in description/patch, are missing.
>>
>> Thanks for your review, @lebedev.ri. This is actually one NFC patch. I think we don't need add new tests.
>
> How is it NFC?

I think @LiuChen3 's NFC firstly means to LLVM. I.e. Moving the manually added check to .inc that generated by tablegen. It's hard to say NFC for the tablegen code. But with a coarse search, I didn't find we have a test for this EVEX2VEX backend. So I assumed it is covered by LLVM tests. By this mean, I think we can call it a NFC :)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98011/new/

https://reviews.llvm.org/D98011