[PATCH] D98167: Avoid shuffle self-assignment in EXPENSIVE_CHECKS builds

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

It seems like https://bugs.llvm.org/show_bug.cgi?id=37652 was fixed upstream.
Do we still want to workaround it?



================
Comment at: llvm/include/llvm/ADT/STLExtras.h:1339
+    difference_type offset = g() % size;
+    if (offset != difference_type(0))
+      std::iter_swap(first, first + offset);
----------------
This should have a comment explaining why this is needed


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98167/new/

https://reviews.llvm.org/D98167