[llvm] f71cee1 - [X86] Break if-else chain. NFCI.

Simon Pilgrim via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 8 03:44:46 PST 2021


Author: Simon Pilgrim
Date: 2021-03-08T11:44:31Z
New Revision: f71cee136d7ea83b21c099e04d5807e2f5cff88e

URL: https://github.com/llvm/llvm-project/commit/f71cee136d7ea83b21c099e04d5807e2f5cff88e
DIFF: https://github.com/llvm/llvm-project/commit/f71cee136d7ea83b21c099e04d5807e2f5cff88e.diff

LOG: [X86] Break if-else chain. NFCI.

Both if blocks affect control flow - we don't need the else.

Fixes clang-tidy warning.

Added: 
    

Modified: 
    llvm/lib/Target/X86/X86ISelLowering.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/X86/X86ISelLowering.cpp b/llvm/lib/Target/X86/X86ISelLowering.cpp
index c24aa0f763c2..d84b8123aef3 100644
--- a/llvm/lib/Target/X86/X86ISelLowering.cpp
+++ b/llvm/lib/Target/X86/X86ISelLowering.cpp
@@ -34452,7 +34452,8 @@ void X86TargetLowering::computeKnownBitsForTargetNode(const SDValue Op,
             // of the shuffle result.
             Known.resetAll();
             break;
-          } else if (M == SM_SentinelZero) {
+          }
+          if (M == SM_SentinelZero) {
             Known.One.clearAllBits();
             continue;
           }


        


More information about the llvm-commits mailing list