[PATCH] D98102: [RISCV] Add support for fixed vector reductions.

Fraser Cormack via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 8 02:13:56 PST 2021


frasercrmck added a comment.

Wow yeah that's some heavy scalarization. I think I came across some situations where custom vector legalization may be required, as you say. It just felt odd, though. Do any other targets have to do this, other than simple hi/lo splitting?



================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:2446
+  if (VecVT.isFixedLengthVector()) {
+    ContainerVT = RISCVTargetLowering::getContainerForFixedLengthVector(
+        DAG, VecVT, Subtarget);
----------------
This (and further down) can now be simplified to `= getContainerForFixedLengthVector(VecVT);` (after rebasing)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98102/new/

https://reviews.llvm.org/D98102



More information about the llvm-commits mailing list