[PATCH] D98011: [X86][NFC] Adding one flag to imply whether the instruction should check the predicate when compress EVEX instructions to VEX encoding.

[LiuChen via Phabricator via llvm-commits]

LiuChen3 added inline comments.


================
Comment at: llvm/utils/TableGen/X86EVEX2VEXTablesEmitter.cpp:206-207
+    }
+    if (Predicates.empty())
+      Predicates = "true";
+    return Predicates;
----------------
pengfei wrote:
> We don't need to add `case XXX return ture` since we use the `default: return true;`.
> And since we always need to check predicate when we add it in the td file, we don't expect the Predicates is empty. I think we can add a assert for this case.
Yes. The default value should be 'llvm_unreachable'. In this case, "return true" is needed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98011/new/

https://reviews.llvm.org/D98011