[PATCH] D98011: [X86] Adding one flag to imply whether the instruction should check the predicate when compress EVEX instructions to VEX encoding.

[LiuChen via Phabricator via llvm-commits]

LiuChen3 added inline comments.


================
Comment at: llvm/utils/TableGen/X86EVEX2VEXTablesEmitter.cpp:202
+        Inst->TheDef->getValueAsListOfDefs("Predicates");
+    for (unsigned i = 0, e = PredicatesRecords.size(); i != e; ++i) {
+      StringRef PredicatesRecordsName = PredicatesRecords[i]->getName();
----------------
pengfei wrote:
> If we can assume the predicates that need to check all started with HasAVXxxx, then we just need to find it in the PredicatesRecords and check it only.
Related to Yuanke's question, if support customized code for CheckPredicate, the name could be something else, so that we can't depend on the whether the predicate starts with "HasAVX". This is also my first thought. What's your opinion here? Of course we can apply your method firstly and added more conditions in the future. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98011/new/

https://reviews.llvm.org/D98011