[PATCH] D98147: [SCEV] Improve modelling for pointer constants

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri marked an inline comment as done.
lebedev.ri added a comment.

Thank you for taking a look!

In D98147#2610104 <https://reviews.llvm.org/D98147#2610104>, @Meinersbur wrote:

> I cannot see the mentioned null constant handling?
> Is it because removing the `ConstantPointerNull` condition it falls back to the generic case that now does handle null constants?

Null constant handling consists of not diffusing `ConstantPointerNull` into an integer zero, but keeping it as a pointer-typed `SCEVUnknown`.

Sorry, i have no clue about polly, i have never looked at it's code.



================
Comment at: polly/test/Isl/CodeGen/partial_write_impossible_restriction.ll:9-10
+
+; FIXME: How to update this test?
+; XFAIL: *
+
----------------
Meinersbur wrote:
> Does it crash or a CHECK-line not match?
```
FAIL: Polly :: Isl/CodeGen/partial_write_impossible_restriction.ll (1 of 1)
******************** TEST 'Polly :: Isl/CodeGen/partial_write_impossible_restriction.ll' FAILED ********************
Script:
--
: 'RUN: at line 1';   opt  -polly-process-unprofitable  -polly-remarks-minimal  -polly-use-llvm-names  -polly-import-jscop-dir=/repositories/llvm-project/polly/test/Isl/CodeGen  -polly-codegen-verify  -polly-stmt-granularity=bb -polly-import-jscop -polly-import-jscop-postfix=transformed -polly-codegen -S < /repositories/llvm-project/polly/test/Isl/CodeGen/partial_write_impossible_restriction.ll | FileCheck /repositories/llvm-project/polly/test/Isl/CodeGen/partial_write_impossible_restriction.ll
--
Exit Code: 2

Command Output (stderr):
--
Reading JScop '%for.body344---%if.then.i.i1141.loopexit' in function 'partial_write_impossible_restriction' from '/repositories/llvm-project/polly/test/Isl/CodeGen/partial_write_impossible_restriction___%for.body344---%if.then.i.i1141.loopexit.jscop.transformed'.
No match for array 'MemRef2' in JScop.
LLVM ERROR: Tried to import a malformed jscop file.
PLEASE submit a bug report to https://bugs.llvm.org/ and include the crash backtrace.

```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98147/new/

https://reviews.llvm.org/D98147