[PATCH] D98086: [FileCheck] Fix numeric error propagation

[Joel E. Denny via Phabricator via llvm-commits]

jdenny updated this revision to Diff 328891.
jdenny retitled this revision from "[FileCheck] Fix CHECK-NOT numeric error diagnostics" to "[FileCheck] Fix numeric error propagation".
jdenny edited the summary of this revision.
jdenny added a comment.

I've generalized this patch to also handle errors that occur **after** matching.  One issue is that `PrintNoMatch` was handling those, but I moved the handling to `PrintMatch` so that we actually report the full match that was found.  That seems like useful information and helps with `-dump-input`.

Also, I started renaming functions I modified significantly to follow the current LLVM style: `printNoMatch` and `printMatch`.  I knows some LLVM projects update style incrementally like this.  I forget if we decided to do that in FileCheck, but I'm happy to revert that part if people don't want to.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98086/new/

https://reviews.llvm.org/D98086

Files:
  llvm/include/llvm/FileCheck/FileCheck.h
  llvm/lib/FileCheck/FileCheck.cpp
  llvm/lib/FileCheck/FileCheckImpl.h
  llvm/test/FileCheck/match-time-error-propagation/invalid-excluded-pattern.txt
  llvm/test/FileCheck/match-time-error-propagation/invalid-expected-pattern.txt
  llvm/test/FileCheck/match-time-error-propagation/matched-excluded-pattern.txt
  llvm/test/FileCheck/match-time-error-propagation/matched-expected-pattern.txt
  llvm/unittests/FileCheck/FileCheckTest.cpp
  llvm/utils/FileCheck/FileCheck.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D98086.328891.patch
Type: text/x-patch
Size: 41867 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210307/4831b111/attachment.bin>