[PATCH] D98148: GlobalISel: Fix marking byval arguments as immutable

[Matt Arsenault via Phabricator via llvm-commits]

arsenm created this revision.
arsenm added reviewers: aemerson, paquette, aditya_nandakumar, dsanders, bogner.
Herald added subscribers: kerbowa, pengfei, atanasyan, jrtc27, hiraditya, arichardson, rovka, nhaehnle, jvesely, sdardis.
arsenm requested review of this revision.
Herald added a subscriber: wdng.
Herald added a project: LLVM.

byval arguments need to be assumed writable. Only implicitly stack
passed arguments which aren't addressable in the IR can be assumed
immutable.

Mips is still broken since for some reason its doing its own thing
with the ValueHandlers (and x86 doesn't actually handle byval
arguments now, although some of the code is there).


https://reviews.llvm.org/D98148

Files:
  llvm/include/llvm/CodeGen/GlobalISel/CallLowering.h
  llvm/lib/CodeGen/GlobalISel/CallLowering.cpp
  llvm/lib/Target/AArch64/GISel/AArch64CallLowering.cpp
  llvm/lib/Target/AMDGPU/AMDGPUCallLowering.cpp
  llvm/lib/Target/ARM/ARMCallLowering.cpp
  llvm/lib/Target/Mips/MipsCallLowering.cpp
  llvm/lib/Target/X86/X86CallLowering.cpp
  llvm/test/CodeGen/AArch64/GlobalISel/irtranslator-stack-objects.ll
  llvm/test/CodeGen/AMDGPU/GlobalISel/irtranslator-function-args.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D98148.328888.patch
Type: text/x-patch
Size: 15382 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210307/6c1c2283/attachment.bin>